Skip to content

HADOOP-18761. Remove mysql-connector-java#5731

Merged
jojochuang merged 2 commits intoapache:trunkfrom
jojochuang:HADOOP-18761-optional
Jun 12, 2023
Merged

HADOOP-18761. Remove mysql-connector-java#5731
jojochuang merged 2 commits intoapache:trunkfrom
jojochuang:HADOOP-18761-optional

Conversation

@jojochuang
Copy link
Contributor

@jojochuang jojochuang commented Jun 9, 2023

Description of PR

mysql-connector-java is GPL licensed. It was included as an optional feature in HDFS RBF.
Fortunately, it looks like we do not need to take compile dependency on it at all. Users who wish to use the feature will need to add it to the runtime classpath.

How was this patch tested?

Built successfully; HDFS RBF unit tests passed.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

jojochuang added 2 commits June 9, 2023 11:05
@jojochuang
HADOOP-18761. Mark mysql-connector-java dependency optional.
af412ec
@jojochuang
Remove mysql-connector-java
eb05258 
There is no compile time dependency on mysql-connector-java so we should simply remove it from pom.xml.
@hadoop-yetus
Copy link

hadoop-yetus commented Jun 10, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 59s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 18m 7s Maven dependency ordering for branch
+1 💚 mvninstall 20m 38s trunk passed
+1 💚 compile 17m 27s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 16m 28s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 4m 25s trunk passed
+1 💚 mvnsite 1m 55s trunk passed
+1 💚 javadoc 1m 56s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 1m 41s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+0 🆗 spotbugs 1m 3s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚 shadedclient 22m 42s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 1m 0s Maven dependency ordering for patch
+1 💚 mvninstall 0m 54s the patch passed
+1 💚 compile 16m 34s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 16m 34s the patch passed
+1 💚 compile 16m 14s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 16m 14s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 4m 22s root: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)
+1 💚 mvnsite 1m 51s the patch passed
+1 💚 javadoc 1m 45s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 1m 40s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+0 🆗 spotbugs 0m 47s hadoop-project has no data from spotbugs
+1 💚 shadedclient 23m 1s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 44s hadoop-project in the patch passed.
+1 💚 unit 23m 21s hadoop-hdfs-rbf in the patch passed.
+1 💚 asflicense 1m 15s The patch does not generate ASF License warnings.
211m 53s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5731/1/artifact/out/Dockerfile
GITHUB PR #5731
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux 8a14120c9392 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / eb05258
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5731/1/testReport/
Max. process+thread count 2171 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5731/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@jojochuang jojochuang merged commit e1bb4ac into apache:trunk Jun 12, 2023
@jojochuang
Copy link
Contributor Author

jojochuang commented Jun 12, 2023

Thanks @goiri I'll also cherry pick the commit into branch-3.3.

asfgit pushed a commit that referenced this pull request Jun 12, 2023
@jojochuang
HADOOP-18761. Remove mysql-connector-java (#5731)
dea53da 
(cherry picked from commit e1bb4ac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goiri goiri goiri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jojochuang @hadoop-yetus @goiri